Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Discord integration (temporarily) #1396

Closed
qaisjp opened this issue Apr 20, 2020 · 1 comment · Fixed by #1407
Closed

Remove Discord integration (temporarily) #1396

qaisjp opened this issue Apr 20, 2020 · 1 comment · Fixed by #1407
Labels
refactor
Milestone
1.5.8

Comments

@qaisjp
Copy link
Contributor

qaisjp commented Apr 20, 2020

Describe the bug

Due to #1370 and #1377 we need to remove the Discord integration.

Expected behaviour

The discord module should not be downloaded or loaded, but CServerInfo which was introduced with the Discord update, should remain. Lua functions should be removed, as well as the on discord join functionality.

Additional context

p.s. this is why PRs should be split up - it would have been easier to just revert the discord commit 🙃 - this is my fault as I let that through despite others' protests
@qaisjp qaisjp added the bug Something isn't working label Apr 20, 2020
@qaisjp qaisjp added this to the 1.5.8 milestone Apr 20, 2020
qaisjp added a commit to qaisjp/mtasa-blue that referenced this issue Apr 25, 2020
@qaisjp
Fix multitheftauto#1396: no-op Discord integration
9f03f61
@qaisjp qaisjp mentioned this issue Apr 25, 2020
Merged
@qaisjp qaisjp added refactor and removed bug Something isn't working labels Apr 25, 2020
@qaisjp
Copy link
Contributor Author

qaisjp commented Apr 25, 2020

In #1407 I chose not to remove the Lua stuff so that 1.5.8 non-nightly servers can still make use of the feature with 1.5.8 nightly clients (when we re-add Discord after 1.5.8 releases).

Please note that setPlayerDiscordJoinParams is still not the final function name - see #1335 and Beta Features.

qaisjp added a commit that referenced this issue Apr 26, 2020
@qaisjp
Fix #1396: no-op Discord integration (#1407)
f6d1ffe
@qaisjp qaisjp mentioned this issue May 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
1.5.8
Development

Successfully merging a pull request may close this issue.

Fix #1396: no-op Discord integration qaisjp/mtasa-blue
1 participant
@qaisjp