Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/msg duplicating when sent by Server Console #1410

Closed
Lord-Henry opened this issue Apr 25, 2020 · 4 comments · Fixed by #1411
Closed

/msg duplicating when sent by Server Console #1410

Lord-Henry opened this issue Apr 25, 2020 · 4 comments · Fixed by #1411
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
1.5.8

Comments

@Lord-Henry
Copy link
Contributor

Describe the bug
When someone uses /msg on Server Console to someone online, that player receives the message twice.

To Reproduce

  1. Start a local server.
  2. Log-in the server.
  3. Go to Server Console and use /msg to send a message to your own character.
  4. Go to the game and see the same message twice.

Expected behavior
Server Console should send the message only once.

Screenshots
Server Console:
screenshot 2020-04-25 144418
Game chat:
screenshot 2020-04-25 144515

Version

  • server/client version: 1.5.7-20447)
  • Windows 10 PRO

Additional context
It seems that are 2 hard coded scripts doing the same thing. Each one sending a message to the player.
@Dezash
Copy link
Contributor

Dezash commented Apr 25, 2020

This is an in-built command. Please create an issue on https://github.com/multitheftauto/mtasa-blue/

@qaisjp
Copy link
Contributor

qaisjp commented Apr 26, 2020

We can transfer issues between repositories - are you are 100% sure this is not a resource related bug @Dezash? Sounds like there's a script that's handling an event but forgetting to cancel it

@Dezash
Copy link
Contributor

Dezash commented Apr 26, 2020

@qaisjp from a quick search, it looks like there's a missing break in the switch statement

mtasa-blue/Server/mods/deathmatch/logic/CConsoleCommands.cpp

Line 598 in 9275095

case CClient::CLIENT_CONSOLE:

@qaisjp
Copy link
Contributor

qaisjp commented Apr 26, 2020

Nice find!

@qaisjp qaisjp transferred this issue from multitheftauto/mtasa-resources Apr 26, 2020
@qaisjp qaisjp added bug Something isn't working good first issue Good for newcomers labels Apr 26, 2020
@qaisjp qaisjp modified the milestones: Backlog, 1.5.8 Apr 26, 2020
@Dezash Dezash mentioned this issue Apr 26, 2020
Merged
qaisjp pushed a commit that referenced this issue Apr 26, 2020
@GabrieliusAdform
Fix #1410: /msg duplicating when sent by Server Console (#1411)
4e1629f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
1.5.8
Development

Successfully merging a pull request may close this issue.

Fix #1410: /msg duplicating when sent by Server Console Dezash/mtasa-blue
3 participants
@qaisjp @Dezash @Lord-Henry