-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Random collisionless objects" still exist #927
Comments
Does it happen during replacing models? Somebody should find a way to reproduce this. |
I have seen that some objects fail to get replaced when the game is minimized (another unreported bug), but i have not found a way to reproduce this here. |
Do you use engineRestoreCOL or engineRestoreModel somewhere? I noticed these functions still cause objects to randomly lose their collision. |
No, what i do is |
https://www.youtube.com/watch?v=iPA7lt-oT1E&feature=youtu.be This is really annoying, one of my scripts does no longer work because object 3065 loses its collision 90% of the time. Stalingrad Railroad: Collisions messed up. |
Could be that this happens because you are replacing an object that has physics by default? Just as 3065 does. Did you test if by replacing other model it just starts working? Try these IDs and see if that bug still happens: 1640 |
Thats the basket ball and i dont even replace it. It just loses collision along with the a51_jetdoor and (most likely) many other objects. It works on some maps and it stops working on others, but it works again when re-loading a map where it is known to work. €DIT: Now i restarted my local server today to test again and the issue does not appear, wtf. |
…exist (multitheftauto#1818)" This reverts commit 0bf7a92.
@qaisjp This issue is not yet resolved. I experience this everyday on my race server. We are on the latest version and this is really ruining the experience for the players. Could this please get reopened and fixed as soon as possible? :) |
Can we revert b6cf87a if de6b51b is not reason for latest crashes? |
This bug is now already back for more than half a year and has only gotten worse in the meantime unfortunately. It happens usually after 30 min to 1 hour of playing DM race maps now and it's really random as to which object(s) will be affected. The object garys_luv_jump seems to be the one that's most affected, but it can really be any object (today I saw it with plasticsgates after 10min of playing). To recap: everyone who is playing in the server at the moment of the bug happening loses collisions for a certain object type. The only way to fix it is by restarting MTA (each client individually) completely, lots of people have tried scripting methods but nothing seems to help at all. It renders the whole gamemode unplayable and affects a lot of servers daily, MTA is losing a lot of players because of this, does someone have a clue as what might be happening here? The average DM player has to restart MTA at least 3-4 times a day when playing a few maps. |
@Pieter-Dewachter wait for PR #1930 and it'll be solved |
Revert "Revert "Revert "Fix multitheftauto#927: "Random collisionless objects" still exist (multitheftauto#1818)" (multitheftauto#1847)" (multitheftauto#1930)" This reverts commit c38a71e.
Re-opened because sadly we had to revert the fix in 2c14639 I hope someone wants to investigate and fix the bug it causes, as fixing "Random collision objects" soon is important to gameplay experience |
I do have a reproduction resource which might help solve this issue. I've talked with TheNormalnij about it month ago, but probably he couldn't fix this. It's quite easy to reproduce that (see https://discord.com/channels/278474088903606273/366384007535001612/787473438687100958). In my case after replacing a building, some furniture objects lose its collisions. Overall i might say it's somewhat related to model replacing and streaming, because:
Reproduction video: |
@majqqq your discord links points to nowhere because the development channel got removed. Please upload it somewhere else. Anyway I would like to point out this issue increased drasticly lately. Last few weeks ago, I encountered this issue on a default gta world model (street, not replaced or anything) aswell as a custom placed object via createObject. I cannot reproduce this issue conistent, but it started to happen on FFS very often recently.
--- start --- --- end --- Nothing to fancy, but heres comes the issue. The uBaseFence object/model never gets this colission bug, it will always have the right colission, yet somehow the uBasePlatform object with model ID 13607 loses colission at some point. I often see players loading the mode and falling through the object due to missing colissions even though it never got replaced for this model ID. Once the affected players restart MTA, the bug is gone and they can stay on the platform. It looks like the colission gets unloaded for the wrong model ID either by misbehaving script (engineReplaceCOL) or some other random effects. As I said previously I cannot reproduce it in a consistent way, but after ~20 rounds of playing this mini mode with dynamicly loading and unloading, I got this issue once so far and only restarting MTA could solve this issue. It was still present if I just rejoined the server without restarting MTA. EDIT: Check the models here: https://dev.prineside.com/en/gtasa_samp_model_id/ |
@ffsPLASMA nothing lost, this link was leading to discussion in #development channel, where i explained how does it works, and I sent same video. I just want to add that starting resource initially doesn't make it collisionless, bug appears just after restarting (either stopping and starting) resource. |
I've tested this bug. Here I share the test result of this bug. Test Model: 3115,3095 assume x,y,z = getElementPosition(localPlayer) And i found something ineteresting: Vehicle didn't fall, and the result of processLineOfSight showed object had collision And I think this is at least model related. Because this still happens even the vehicle and my CJ stand on different objects whose model are 3115. 1.The test result shows when localPlayer is outside of that area, model 3115 will be collisionless. 2.And this "feature" will be inherited when using "engineRequestModel" 3.engineRestreamWorld doesn't help. 4.getElementCollisionsEnabled returns true even the object is collisionless 5.When losing collisions, 3115 and 3095 are at the same time. |
This code can help to know when this issue happens |
I'm having the same problem on the server I am working on. When you join a server with custom models and then join a server without custom models, some objects lose collisions (ID 2990). |
Your issue is related to #377 |
reproduced |
Describe the bug
Months ago MTA team fixed a bug that caused random objects to lose collisions.
Most users reported that this bug has been fixed once and for all.
Shortly after that fix i noticed some collisionless objects again but they were extremely rare and i thought i am crazy, but now i can confirm that this bug still exists, it is just much more rare.
A reconnect does not fix it.
crun for i, obj in pairs(getElementsByType("object")) do setElementCollisionsEnabled(obj, true) end
--> This does not fix it either.
Only restarting MTA fixes this
To reproduce
No idea. Sometimes a random object loses its collision. I have that issue in Map editor (with custom objects) and on my server.
Screenshots
![image](https://user-images.githubusercontent.com/923242/66269142-de7e1f00-e83c-11e9-80a0-ca8f0b29652f.png)
Version 1.5.6-release-16718
The text was updated successfully, but these errors were encountered: