Skip to content

Conversation

botder
Copy link
Member

@botder botder commented Aug 6, 2021

Supersedes pull request #2289 (Fix all objects in a specific ide will lose their collisions after restoring collisions).

  • Added hooks for object creation and destruction to increase and decrease the collision slot of the original collision model, respectively.
  • Improved the interface structures for GTA:SA and added compile-time sizeof verification.
  • Added CColStore interface
  • Simplified collision replacement code in CModelInfoSA
  • Fixed memory leak in CClientColModel::~CClientColModel() by destroying the internal CColModel through the intended virtual method.
  • Fixed a case where collision model data was unavailable (read: object was collisionless) until the camera/player moved far away and back.

@botder botder added the bug Something isn't working label Aug 6, 2021
@botder botder added this to the Next Release (1.5.9) milestone Aug 6, 2021
@botder botder linked an issue Aug 7, 2021 that may be closed by this pull request
Copy link
Contributor

@Pirulax Pirulax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although as per discussion we're leaving HN behind (although not officially), I'd still recommend it's usage in the GameSA project, as it already heavily uses it.
Also in this discussion it was agreed on (from what I see) to keep the m_ prefix. So please do that.
Other than that I see no glaring issues with the code.
I haven't tested it myself, or looked to deeply into it. (But I hope you did)

I'll approve it for the sake of approving it (as a nightly will definitely show issues if theres any).

Thanks for your time 😁

@botder botder merged commit 34b4a61 into multitheftauto:master Aug 10, 2021
@botder botder deleted the feature/collisionless branch August 10, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Random collisionless objects" still exist
2 participants