-
-
Notifications
You must be signed in to change notification settings - Fork 487
Resolve remaining collisionless objects (Fixes #927) #2296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although as per discussion we're leaving HN behind (although not officially), I'd still recommend it's usage in the GameSA project, as it already heavily uses it.
Also in this discussion it was agreed on (from what I see) to keep the m_
prefix. So please do that.
Other than that I see no glaring issues with the code.
I haven't tested it myself, or looked to deeply into it. (But I hope you did)
I'll approve it for the sake of approving it (as a nightly will definitely show issues if theres any).
Thanks for your time 😁
Co-authored-by: Pirulax <patrikjankovics7@gmail.com>
Co-authored-by: Pirulax <patrikjankovics7@gmail.com>
Supersedes pull request #2289 (Fix all objects in a specific ide will lose their collisions after restoring collisions).
sizeof
verification.CClientColModel::~CClientColModel()
by destroying the internalCColModel
through the intended virtual method.