Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make setAccountSerial() function #281

Closed
PlatinMTA opened this issue Jul 29, 2018 · 5 comments
Closed

Make setAccountSerial() function #281

PlatinMTA opened this issue Jul 29, 2018 · 5 comments
Labels
enhancement New feature or request

Comments

@PlatinMTA
Copy link
Contributor

Hi! On my own server I have a system that checks whenever the serial account is the same to the PC serial, if thats the case they log in, if not, the system checks other stuff.

The thing is that this serial changes to the serial of the PC that it logged last (if that sentence makes sense), so in order to check I need to get the account and account serial, and do the checks.

I think this is very annoying, because if one mistake is made, the serial could be one that isn't meant to be.

So I was thinking now that some people gave the function getAccountByID() and setAccountName(), maybe you could work on setAccountSerial(). This maybe could help some people which are still using the main MTA db instead of MySQL for example.

Thanks!

@qaisjp
Copy link
Contributor

qaisjp commented Jul 29, 2018

Does setAccountData('serial', serial) fit your use case?

@CrosRoad95
Copy link
Contributor

This could be never added to mta due some programmers are dummy. You could disable auth serial if you want and use your own check's, security etc.

@patrikjuvonen
Copy link
Contributor

patrikjuvonen commented Jul 29, 2018

Some servers have worked around this issue by having a fixed length list of user-defined/pre-approved serials that they allow using their account.

Related Mantis issue: https://bugs.mtasa.com/view.php?id=9862

@PlatinMTA
Copy link
Contributor Author

There are ways to make what I want without editing the Serial. Using and accountData is one, but I think that isn't really needed if you can just, you know, edit the one you have.

@patrikjuvonen patrikjuvonen added new feature enhancement New feature or request and removed new feature labels Aug 5, 2018
@botder botder added this to the Backlog milestone Mar 3, 2019
@Lpsd
Copy link
Member

Lpsd commented May 4, 2021

I don't think we need a dedicated function for this when you can already implement it with setAccountData, or your own database.

This issue has been inactive for 3 years, so I'll close this. If you can provide a good reason why this function is needed and you can't use existing functionality to achieve it, please feel free to comment.

@Lpsd Lpsd closed this as completed May 4, 2021
@Lpsd Lpsd removed this from the Backlog milestone May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants