Assuming you've forgotten to uncomment the code?

Also, the wording should be Expected number less than, or equal to 4096 at argument 1 since you're comparing as x > 4096

Assuming you've forgotten to uncomment the code?

Also, the wording should be Expected number <less/greater> than, or equal to 4096 at argument 1 since you're comparing as x > 4096

Hmm, github desktop automatically commented code out, weird.

This will break current behavior of dxCreateTexture.

Also as far as I know it crashes (in really rare cases) only if setPixels is used. So if you wanna block anything higher than 4096 (in my opinion a bad idea) then it makes sense to patch setPixels leaving dxCreateTexture unchanged. Or better just don't patch anything and put a giant warning on wiki about dimensions higher than 4096.

We shouldn't allow textures larger than the API specification regardless

e? people are using bigger textures for radar, does it break backward compatibility?

This will break current behavior of dxCreateTexture.

Also as far as I know it crashes (in really rare cases) only if setPixels is used. So if you wanna block anything higher than 4096 (in my opinion a bad idea) then it makes sense to patch setPixels leaving dxCreateTexture unchanged. Or better just don't patch anything and put a giant warning on wiki about dimensions higher than 4096.

If you check test resource and code, you will notice it only blocks it when creating textures by giving pixels, using image that have even 20kx20k is fine.

No idea why, and how it works - but it does.

possibly. but I feel like we often make decisions based on bad practices in existing scripts and being scared of breaking those. We really should care less if someone's spaghetti script breaks in a major release (1.6) due to beneficial changes (conforming to API specifications) and they are unable to access original source or don't have the knowledge to upgrade it.

Let's consider this for 1.6

You really don't need to be creating textures larger than 4096, and if for some reason you do need textures larger than this you can just use multiple textures...

e? people are using bigger textures for radar, does it break backward compatibility?

Breaking BWC for crash fixes was done before a lot of times, i think its ok to do this.

Or better just don't patch anything and put a giant warning on wiki about dimensions higher than 4096.

This does precisely nothing. See MySQL module

See discussion on MTA development discord (just search for 4096, lol) - I don't agree now to clamp this, as the underlying issue is more likely related to setPixel itself so we're just covering up the issue here.

The texture size limit comes from GPU, not the DX9 specification (100% sure it used to be in the specification by Microsoft, but later removed).

We need to investigate #287 properly