Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when dxCreateTexture higher than 4096 pixels #2737

Closed
wants to merge 4 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Client/mods/deathmatch/logic/luadefs/CLuaDrawingDefs.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1001,7 +1001,11 @@ int CLuaDrawingDefs::DxCreateTexture(lua_State* luaVM)
// element dxCreateTexture( int width, int height [, string textureFormat = "argb", string textureEdge = "wrap", string textureType = "2d", int depth ]
// )
argStream.ReadNumber(width);
if (width > 4096)
argStream.SetCustomError("Expected number less than, or equal to 4096 at argument 1");
argStream.ReadNumber(height);
if (height > 4096)
argStream.SetCustomError("Expected number less than, or equal to 4096 at argument 2");
argStream.ReadEnumString(renderFormat, RFORMAT_UNKNOWN);
argStream.ReadEnumString(textureAddress, TADDRESS_WRAP);
argStream.ReadEnumString(textureType, TTYPE_TEXTURE);
Expand Down