Crash when using dxDrawText with very long strings

[Pirulax]

Describe the bug
So, I made a stat resource, which displays stats, with, you nailed it: dxDrawText+dxDrawRectangle(bg)

To Reproduce
Steps to reproduce the behavior:

1. Download this this resource
2. Start it
3. Let it run, and you'll start having frame drop. A lot of it.
4. Craaash

MTA Client (please complete the following information):

• Version: Multi Theft Auto v1.5.5-release-12411
• Running in Wine? No

MTA Server (please complete the following information):

• OS: Microsoft Windows [Version 10.0.17134.165]
• Version Multi Theft Auto Server v1.5.5-release-12411

[Pirulax]

Ohh, yeah, and which crash dump should I post?
Because I have a few here.
I mean should I post only dumps/public, or I can post dumps/private too?

[Pirulax]

Actually, I suppose what caused the issue was that I constantly made my text bigger, so the text always got bigger(every 1s) with ^2 of its size.
So, I suppose the text got too long, and thats what caused the issue.
Maybe clamping it'd solve the crash?

[qaisjp]

Can you clear your dump folder, reproduce this crash, and then upload the dump and send us a link to upload.mtasa.com. If you can also do this for the other issue you've reported (#287) that would be great. Thanks.

…

On Thu, 2 Aug 2018 at 14:03, Pirulax ***@***.***> wrote: Ohh, yeah, and which crash dump should I post? Because I have a few here. I mean should I post only dumps/public, or I can post dumps/private too? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#288 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA4WamLMS5V2EnkJWaD8yq043c0yYhQ4ks5uMviCgaJpZM4VsPVe> .

[qaisjp]

please send both public and private in a zip, thanks

…

On Thu, 2 Aug 2018 at 14:10, Qais Patankar ***@***.***> wrote: Can you clear your dump folder, reproduce this crash, and then upload the dump and send us a link to upload.mtasa.com. If you can also do this for the other issue you've reported (#287) that would be great. Thanks. On Thu, 2 Aug 2018 at 14:03, Pirulax ***@***.***> wrote: > Ohh, yeah, and which crash dump should I post? > Because I have a few here. > I mean should I post only dumps/public, or I can post dumps/private too? > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#288 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AA4WamLMS5V2EnkJWaD8yq043c0yYhQ4ks5uMviCgaJpZM4VsPVe> > . >

[Pirulax]

https://upload.mtasa.com/u/295892534/dxcrash.zip_

[tederis]

As far as I know ID3DXFont::DrawText is designed to rasterize a text on top of RT. If that is the case, the reason is pretty clear. DirectX 9 is limited to up to 4096x4096 pixels for texture sizes. When you are trying to draw a text that far exceeds that limit you happen to be in area where anything could happen. Well, I wouldn't call it 'a bug'. The only visible way in there is to check if a text is big enough and clamp it if needed.

[Lpsd]

Probably related to and can be resolved along with #287