Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMG containers kept being in use even after disconnecting from server #3115

Closed
1 task done
PlatinMTA opened this issue Jul 10, 2023 · 2 comments
Closed
1 task done
Labels
bug Something isn't working

Comments

@PlatinMTA
Copy link
Contributor

PlatinMTA commented Jul 10, 2023

Describe the bug

After loading an IMG Container you will not be able to delete or edit it in the same session. You need to restart your MTA for the file to stop being 'in use'.

image
In this picture I'm unable to delete the .IMG file even tho I'm not connected to any server.

Steps to reproduce

  1. Load an IMG Container, for example:
local imgSkins = engineLoadIMG("skins.img")
engineAddImage(imgSkins)
  1. After being loaded, you will be unable to change it until you restart your game. Try deleting it.

Version

Client: 1.6 r21855

Additional context

This will keep happening even after destroying the IMG Container using destroyElement. This is particulary problematic because if you make changes on your .IMG file via a server update, and the client tries to download the file, it will be downloaded but the file will never be replaced, meaning that the old .IMG file is still on the client. This could let the users use custom skins via your .IMG file by using a custom server.

This shouldn't be a problem tho if you use '@' on your .IMG path, but you shouldn't need to do that in the first place.

Relevant log output

No response

Security Policy

  • I have read and understood the Security Policy and this issue is not security related.
@PlatinMTA PlatinMTA added the bug Something isn't working label Jul 10, 2023
@tederis
Copy link
Collaborator

tederis commented Jul 10, 2023

Should be fixed in r21888(in relation to PR #3110)

@PlatinMTA
Copy link
Contributor Author

Yes, this particular issue is fixed, thank you.

However you can still manipulate MTA to not replace your IMG container (even in admin), which I guess could be done for every file if the client really wanted to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants