Fix CStreamingSA::GetUnusedStreamHandle #3110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maybe thats why streaming flickering and this can fix issue mentioned here #3092 |
nah the flickering/artifacting fixed in that PR is caused specifically by a bug in the bone animation code which is just exacerbated by higher memory usage (which is why it never occurred on the PS2) |
Merged
|
lgtm, tested |
TheNormalnij
approved these changes
Jul 9, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like CStreamingSA::GetUnusedArchive returns not what is declared in the method's name. It always returns 0 that leads to an unexpected behaviour when engineAddImage called. engineAddImage is always adding an image to a slot 6. And furthermore, it can break the default SA streaming because of overriding of the first streaming handle.