Thanks for the bugfix. Code looks fine but won't approve as I haven't actually tested it.

This change isn't limited to peds, so in what way does this change affect players?

It does not affect players in any way. It only causes that the 'reborn' ped is not indestructible.

@FileEX what can we do to help you fix this issue?

(@patrikjuvonen i've removed the WIP prefix because it didn't look like this PR was a draft — feel free to undo my undo)

@patrikjuvonen is right. The crash comes from m_pTaskManager->RemoveTask(TASK_SIMPLE_DEAD);
You are passing a task type to m_pTaskManager->RemoveTask instead of passing the primary task index. There are only 5 primary tasks. Take a look at this:

enum
{
    TASK_PRIORITY_PHYSICAL_RESPONSE = 0,
    TASK_PRIORITY_EVENT_RESPONSE_TEMP,
    TASK_PRIORITY_EVENT_RESPONSE_NONTEMP,
    TASK_PRIORITY_PRIMARY,
    TASK_PRIORITY_DEFAULT,
    TASK_PRIORITY_MAX
};

This means the range of primary task index is 0 to 4. The value of TASK_SIMPLE_DEAD is 218; hence it causes a crash.

TASK_SIMPLE_DEAD is set to TASK_PRIORITY_EVENT_RESPONSE_NONTEMP. This means, your code should look like this if you want to remove the task:

m_pTaskManager->RemoveTask(TASK_PRIORITY_EVENT_RESPONSE_NONTEMP);

Obviously, this requires testing. We'll have to confirm that it doesn't cause any bugs.

Changed

Reverted in 159d291