-
-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onPickupLeave+setDimension #846
Comments
Can you use the Bug report issue template next time? Your description is lacking information. |
|
Clientmtasa-blue/Client/mods/deathmatch/logic/CClientPickup.cpp Lines 196 to 214 in d47332e
Servermtasa-blue/Server/mods/deathmatch/logic/CPickup.cpp Lines 514 to 541 in d47332e
Proposed solutionChange
We could also do the same for |
Actually I think it's good that onPickupLeave server-side currently only triggers for matching interiors and dimensions. I am not sure what to do if the user leaves a pickup by teleporting to another dimension. It should probably trigger the event even though the dimension/interior is different, as the player has technically left the pickup. I have a hunch that the clientside argument was only added in the name of backwards compatibility Thoughts @botder? |
I really dislike keeping backwards compatibility in such cases, because the next scripter might not expect this odd behavior - he probably expects that leaving the pickup's dimension/interior should trigger the event. |
I agree we should add a fix for the second half. My backwards compatibility comment is only relating to the first half.
This meant that the client-side event probably originally used to always trigger (regardless of dimension and interior). So they added My argument is that it is good that onPickupLeave does not trigger when you pickup is in a different dimension. i.e., we should not remove the dimension/interior checks on the server side. Also, on the client, Does that make sense? |
Refresh, is it fixed? |
onPickupLeave do not detect the dimension change,idk how about interior.
The text was updated successfully, but these errors were encountered: