Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dxDrawCircle segments argument #1079

Merged
merged 2 commits into from Sep 4, 2019
Merged

Fix dxDrawCircle segments argument #1079

merged 2 commits into from Sep 4, 2019

Conversation

ApeLsiN4eG
Copy link
Contributor

Fixed a bug when it drew number of segments-1 segments instead of number of segments that you pass in the segments argument of the dxDrawCircle function.

For example:
dxDrawCircle(500, 500, 100, 0, 360, tocolor(255,255,255,255), tocolor(255,255,255,255), 4) draws a triangle with 3 segments instead of a square.
dxDrawCircle(500, 500, 100, 0, 360, tocolor(255,255,255,255), tocolor(255,255,255,255), 3) draws nothing.

	modified:   Client/core/Graphics/CGraphics.cpp
@patrikjuvonen patrikjuvonen added the bug Something isn't working label Sep 4, 2019
@patrikjuvonen patrikjuvonen added this to the 1.6 milestone Sep 4, 2019
@patrikjuvonen patrikjuvonen self-assigned this Sep 4, 2019
@patrikjuvonen
Copy link
Contributor

👍

Nice one!
Thank you for the PR and congratulations on your first contribution! =)

Small sidenote: in the future when you make a patch, I suggest you create a new branch such as bugfix/wrong-segment-count-in-dxDrawCircle and create a pull request from there instead of directly from your master branch, as this way you can keep different bugfixes and features separated from each other and makes the whole process troubleless for both sides. Your master branch should basically always be identical to our master branch.

@patrikjuvonen patrikjuvonen merged commit 006fe68 into multitheftauto:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants