Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1336: Discord Rich Presence not respecting CVars load #1345

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Fix #1336: Discord Rich Presence not respecting CVars load #1345

merged 1 commit into from
Apr 3, 2020

Conversation

0x416c69
Copy link
Contributor

@0x416c69 0x416c69 commented Apr 3, 2020

This closes #1336

@0x416c69 0x416c69 mentioned this pull request Apr 3, 2020
Closed
qaisjp
qaisjp approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@qaisjp qaisjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the quick hotfix

@StrixG StrixG changed the title Fix a bug with discord rich presence not respecting CVars load Fix a bug with Discord Rich Presence not respecting CVars load Apr 3, 2020
@qaisjp qaisjp changed the title Fix a bug with Discord Rich Presence not respecting CVars load Fix #1336: Discord Rich Presence not respecting CVars load Apr 3, 2020
@qaisjp qaisjp merged commit a4f447a into multitheftauto:master Apr 3, 2020
@qaisjp qaisjp added this to the 1.6 milestone Apr 3, 2020
patrikjuvonen pushed a commit that referenced this pull request Apr 6, 2020
@0x416c69
Fix #1349 crash introduced in PR #1345 (#1350)
3d92acd 
* Fix a bug with discord rich presence not respecting CVars load

* Fix crash at #1349

* Fix coding style
@patrikjuvonen patrikjuvonen added the bug Something isn't working label Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qaisjp qaisjp qaisjp approved these changes

@StrixG StrixG StrixG approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.5.8
Development

Successfully merging this pull request may close these issues.

Rich Presence still showing even if the option is unchecked
4 participants
@0x416c69 @qaisjp @StrixG @patrikjuvonen