Save server row index instead of finding it #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for this PR. I was trying to figure out where the caching opportunity was here on my own but my unfamiliarity with c++ really hindered me. |
qaisjp
approved these changes
Oct 15, 2020
Woovie
suggested changes
Oct 15, 2020
Woovie
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving/Caching the row index of each server in server list allow us to avoid making unnecesary for-loop (for each server) to find if the row already exists. For example on the first load, where the first action is just to add (not update nor remove), avoiding this will increase the performance a lot and it won't get so much time to load.