Make sure BitStream comparisons still work correctly #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following issue:
Currently we have this
```cpp
enum class eBitStreamVersion : unsigned short
{
Unk = 0x06F,
Latest
};
```
our bitstream version (Latest) is 0x070
If we add a feature, like so:
```
enum class eBitStreamVersion : unsigned short
{
Unk = 0x06F,
NewThing,
Latest
};
```
Latest becomes 0x071. But bitstream checks will compare against NewThing (0x070) which
matches old client/servers whose latest is also 0x070
ccw808
approved these changes
Oct 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following issue:
Currently we have this
our bitstream version (Latest) is 0x070
If we add a feature, like so:
Latest becomes 0x071. But bitstream checks will compare against NewThing (0x070) which
matches old client/servers whose latest is also 0x070