Add final where possible - server #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pirulax
force-pushed
the
refactor/add-finalizers/server
branch
from
b814108
to
c5ead28
Compare
ghost
approved these changes
Nov 4, 2020
If so, I think whoever merges this should be careful to make sure it isn't caught in a huge build, otherwise it'll be hard to bisect nightlies and determine if this caused an issue. |
|
Im saying this based on my experience with MTA code, theres quite some questionable stuff going on. Also.. We could group up the changes here by class type into separate PRs, so if anything goes wrong we're going to have a separate nightly for each PR. Edit: Al-tough, I dont think It will cause any issues here(on the server), but rather on the client. |
ghost
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR, but separated:
Adding the final keyword allows the compiler to "devirtualize" (virtual) calls, aka inline them.
This will probably blow some hacky code up pretty hard, im sure.