Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable train track functions #1920

Merged
merged 5 commits into from
Dec 29, 2020
Merged

Disable train track functions #1920

merged 5 commits into from
Dec 29, 2020

Conversation

qaisjp
Copy link
Contributor

@qaisjp qaisjp commented Dec 15, 2020

Custom train tracks is incomplete and requires further iteration before being a full MTA release.

Since I'm no longer working on MTA and cannot continue iterating on this train tracks work, this PR disables some functions that were turned on in #1715.

If you want to continue the work, feel free to refer to #250

That branch is kinda broken (crashes or freezes when you get in a train, last I checked), but most of the code works. I was aiming to fix that freezing problem by slowly iterating: submitting working PRs to master and adding small features bit by bit.

So if you want to continue the train tracks work, you'll probably have to rewrite most of it (or manually copy chunks bit by bit) from the huge train tracks branch. I used a git worktree to keep two branches checked out in the same git repository (instead of cloning twice).

Copy link
Contributor

@Pirulax Pirulax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if it doesnt break existing scripts.

@qaisjp
Copy link
Contributor Author

qaisjp commented Dec 28, 2020

This function is part of an incomplete API, and as it's not part of any release, it had no compatibility guarantees. In that sense, it does not break any production scripts.

Please merge at your convenience.

@Pirulax Pirulax merged commit 32d68e0 into multitheftauto:master Dec 29, 2020
@qaisjp qaisjp deleted the patch-1 branch December 29, 2020 01:02
@patrikjuvonen patrikjuvonen added this to the 1.6 milestone Dec 29, 2020
@patrikjuvonen patrikjuvonen added the enhancement New feature or request label Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants