0008957: add missing vertical scrollbar functions to gui memo element #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, I could've named the commit better by adding memo to it, but oh well... |
qaisjp
reviewed
Jul 22, 2018
| @@ -320,9 +322,15 @@ void CLuaGUIDefs::AddGuiMemoClass(lua_State* luaVM) | |||
| lua_classfunction(luaVM, "setCaretIndex", "guiMemoSetCaretIndex"); | |||
| lua_classfunction(luaVM, "setReadOnly", "guiMemoSetReadOnly"); | |||
|
|
|||
| lua_classfunction(luaVM, "getVerticalScrollPosition", "guiMemoGetVerticalScrollPosition"); | |||
There was a problem hiding this comment.
this line should sit with getCaretIndex
There was a problem hiding this comment.
Thanks. Done.
qaisjp
reviewed
Jul 22, 2018
| @@ -320,9 +322,15 @@ void CLuaGUIDefs::AddGuiMemoClass(lua_State* luaVM) | |||
| lua_classfunction(luaVM, "setCaretIndex", "guiMemoSetCaretIndex"); | |||
| lua_classfunction(luaVM, "setReadOnly", "guiMemoSetReadOnly"); | |||
|
|
|||
| lua_classfunction(luaVM, "getVerticalScrollPosition", "guiMemoGetVerticalScrollPosition"); | |||
|
|
|||
| lua_classfunction(luaVM, "setVerticalScrollPosition", "guiMemoSetVerticalScrollPosition"); | |||
There was a problem hiding this comment.
this line should sit with setCaretIndex
There was a problem hiding this comment.
Thanks. Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mantis Bug Tracker issue:
8957
Summary:
guiMemoSetVerticalScrollPositionandguiMemoGetVerticalScrollPosition;guiMemoSetVerticalScrollPositiontakes in a float between 0 and 100;guiMemoGetVerticalScrollPositionreturns a float between 0 and 100;Note about guiMemoGetMaxVerticalScrollPosition (1a8dc0e):
guiMemoGetMaxVerticalScrollPosition, which would return(document size - page size). However, @qaisjp and I ended up thinking it is unnecessary for now. If we ever want to implement it, the code is ready in 1a8dc0e.