Add discord-rpc #2577
Closed
Add discord-rpc #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
CrosRoad95
reviewed
Apr 11, 2022
Closed
botder
requested changes
Jul 27, 2022
Co-authored-by: Marek Kulik <me@botder.com>
Co-authored-by: Marek Kulik <me@botder.com>
botder suggestion
botder suggestion
Fix uppercase
botder suggestion
botder suggestion
|
I think we can prioritize making customization features for servers to decide what shows on their players' Discord Rich Presence when in-game. Imo, the PR can be merged once this is complete. Then, allowing servers to integrate custom applications to their servers is something that can be addressed separately. |
|
This draft pull request is stale because it has been open for at least 90 days with no activity. Please continue on your draft pull request or it will be closed in 30 days automatically. |
|
This draft pull request was closed because it has been marked stale for 30 days with no activity. |
|
We need someone to adopt this PR |
znvjder
added a commit
to znvjder/mtasa-blue
that referenced
this pull request
Aug 28, 2023
znvjder
added a commit
to znvjder/mtasa-blue
that referenced
this pull request
Aug 28, 2023
Lpsd
added a commit
that referenced
this pull request
Oct 11, 2023
* get draft from #2577 * get draft from #2577 * add checkbox to allow connecting with discord-rpc test case with load data * safe delete only if used * fix vars when game is launching * add function to set appid and small fixes * added functions to manage assets, small fixes and bugs * rewriten setAsset, refactor littlebit * add function to check client connection with discord * add buttons to rpc * minor amendments, renaming of functions * remove update discord-rpc from build * thats too * Memory leak fixed, presence updated on app change * Presence state change, change of time variable * Fixed unable to change custom state * Added const to IsDiscordRPCEnabled * Added missing argument validation * Exclude vendor files, added premake script * Re-run actions * Bump discord-rpc version * Fix broken discord tag_name * Bump discord-rpc version * Revert to 2b42cd9 * Bump discord-rpc version * Disabled data customization if the app is not own * Change DEFAULT_APP_ID * Remove comment --------- Co-authored-by: Lpsd <40902730+Lpsd@users.noreply.github.com>
|
Superseded by #3167 |
TracerDS
pushed a commit
to TracerDS/mtasa-blue
that referenced
this pull request
Feb 2, 2024
* get draft from multitheftauto#2577 * get draft from multitheftauto#2577 * add checkbox to allow connecting with discord-rpc test case with load data * safe delete only if used * fix vars when game is launching * add function to set appid and small fixes * added functions to manage assets, small fixes and bugs * rewriten setAsset, refactor littlebit * add function to check client connection with discord * add buttons to rpc * minor amendments, renaming of functions * remove update discord-rpc from build * thats too * Memory leak fixed, presence updated on app change * Presence state change, change of time variable * Fixed unable to change custom state * Added const to IsDiscordRPCEnabled * Added missing argument validation * Exclude vendor files, added premake script * Re-run actions * Bump discord-rpc version * Fix broken discord tag_name * Bump discord-rpc version * Revert to 2b42cd9 * Bump discord-rpc version * Disabled data customization if the app is not own * Change DEFAULT_APP_ID * Remove comment --------- Co-authored-by: Lpsd <40902730+Lpsd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2499
Prior discussions/implementations #721, #1031, #1570
This PR adds basic discord-rpc features to the client.
(Other features will be added later on a separate PR)
Todo:
Maybe: