Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix weapon zoom behavior #2769

Closed
wants to merge 6 commits into from
Closed

Fix weapon zoom behavior #2769

wants to merge 6 commits into from

Conversation

darkdrifter
Copy link
Contributor

@darkdrifter darkdrifter commented Sep 28, 2022 •
edited
Loading

This PR is aimed to fix several issues present in the weapon zoom right now.
Created after discussions and findings in PR #2767

  • Issue Can't unbind wheel (zoom in/out) #515, which is probably caused by the fact that single player bindings currently affects MTA (if zoom is bound on mouse scroll wheel in solo, it will be usable in MTA, even if not bound or controls are disabled) currently fixed by this hotfix
  • Fixing zoom when using mouse scrolling, which is currently different than in single player, due to the fact that MTA doesn't seems to utilize the Direct Input mouse wheel values value like single player to control the zoom

@darkdrifter
Fix weapon zoom getting affected by single player
eb8acf8 
Fix weapon zoom in/out getting affected by single player key bindings.

We now hook Direct Input scroll wheel data as the game seems to use this value rather than the windows messaging system to handle zoom.
@lopezloo lopezloo added the bug Something isn't working label Sep 28, 2022
@lopezloo lopezloo mentioned this pull request Oct 21, 2022
Merged
@lopezloo
Copy link
Member

lopezloo commented Nov 1, 2022 •
edited
Loading

Zoom seems to be jittery at current state. IMO we just should call CControllerConfigManager::SetMouseButtonAssociatedWithAction() and let GTA handle wheel zooming.

@darkdrifter
Copy link
Contributor Author

darkdrifter commented Dec 27, 2022 •
edited
Loading

Zoom seems to be jittery at current state. IMO we just should call CControllerConfigManager::SetMouseButtonAssociatedWithAction() and let GTA handle wheel zooming.

I agree, but the function isn't implemented currently in MTA. Need some help from someone more experimented to add the function as I can't find the function pointer to use for it and then I could take a look to improve the behaviour.
I might need the CControllerConfigManager::GetMouseButtonAssociatedWithAction function also.

@github-actions github-actions bot added the stale Inactive for over 90 days, to be closed label Mar 28, 2023
@github-actions
Copy link
Contributor

This draft pull request is stale because it has been open for at least 90 days with no activity. Please continue on your draft pull request or it will be closed in 30 days automatically.

@github-actions github-actions bot closed this Apr 28, 2023
@github-actions
Copy link
Contributor

This draft pull request was closed because it has been marked stale for 30 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working stale Inactive for over 90 days, to be closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@darkdrifter @lopezloo