-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ZIP vendor #3057
Update ZIP vendor #3057
Conversation
Moved all zip functionality into `CZipMaker` class
Added the ability to actually create/open zip archives from Lua
I don't have time to go through all the checks but I think that CZipFile won't be deleted after the resource stop. On the contrary, fileOpen creates an element that will be destroyed as resource get stopped. I think you should take a look at how default file functions are implemented and follow the same idea. |
I did try following it but due to how mta is designed i couldnt follow up with the implementation ;/ |
Added more functions and improved stability
This draft pull request is stale because it has been open for at least 90 days with no activity. Please continue on your draft pull request or it will be closed in 30 days automatically. |
This draft pull request was closed because it has been marked stale for 30 days with no activity. |
Main purpose of this PR is to move all zip functionality into one shared class with easy to use API.
The old vendor is... not easy to use