Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ZIP vendor #3057

Closed
wants to merge 6 commits into from
Closed

Conversation

TracerDS
Copy link
Contributor

@TracerDS TracerDS commented Jun 4, 2023

Main purpose of this PR is to move all zip functionality into one shared class with easy to use API.
The old vendor is... not easy to use

Moved all zip functionality into `CZipMaker` class
@lopezloo lopezloo added enhancement New feature or request upstream Related to vendor library labels Jun 5, 2023
Added the ability to actually create/open zip archives from Lua
Server/mods/deathmatch/utils/CZipMaker.cpp Show resolved Hide resolved
Server/mods/deathmatch/utils/CZipMaker.h Outdated Show resolved Hide resolved
Server/mods/deathmatch/utils/CZipMaker.cpp Show resolved Hide resolved
Server/mods/deathmatch/utils/CZipMaker.cpp Outdated Show resolved Hide resolved
Server/mods/deathmatch/utils/CZipMaker.cpp Show resolved Hide resolved
Shared/sdk/version.h Outdated Show resolved Hide resolved
@tederis
Copy link
Collaborator

tederis commented Jun 5, 2023

I don't have time to go through all the checks but I think that CZipFile won't be deleted after the resource stop. On the contrary, fileOpen creates an element that will be destroyed as resource get stopped. I think you should take a look at how default file functions are implemented and follow the same idea.

@TracerDS
Copy link
Contributor Author

TracerDS commented Jun 5, 2023

I don't have time to go through all the checks but I think that CZipFile won't be deleted after the resource stop. On the contrary, fileOpen creates an element that will be destroyed as resource get stopped. I think you should take a look at how default file functions are implemented and follow the same idea.

I did try following it but due to how mta is designed i couldnt follow up with the implementation ;/

Copy link
Contributor

This draft pull request is stale because it has been open for at least 90 days with no activity. Please continue on your draft pull request or it will be closed in 30 days automatically.

@github-actions github-actions bot added the stale Inactive for over 90 days, to be closed label Nov 12, 2023
@github-actions github-actions bot closed this Dec 13, 2023
Copy link
Contributor

This draft pull request was closed because it has been marked stale for 30 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale Inactive for over 90 days, to be closed upstream Related to vendor library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants