Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discord RPC tweaks (from nightly feedback) #3205

Closed
wants to merge 26 commits into from
Closed

Discord RPC tweaks (from nightly feedback) #3205

wants to merge 26 commits into from

Commits on Oct 12, 2023

  1. Add server name to presence state 

    Also fixes some edge cases where the rich presence won't be displayed properly (after enabling it for the first time, or when disconnecting from a server)
    @Lpsd
    Lpsd committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    bf80916 View commit details
    Browse the repository at this point in the history

  2. Remove unused method in CDiscordRichPresence

    @Lpsd
    Lpsd committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    55d6b76 View commit details
    Browse the repository at this point in the history

  3. Modify state formatting

    @Lpsd
    Lpsd committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    061ef41 View commit details
    Browse the repository at this point in the history

  4. Move CCore::GetLastConnectedServerName definition to header

    @Lpsd
    Lpsd committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    8240c85 View commit details
    Browse the repository at this point in the history

  5. Allow setting start time & party size via Lua

    @Lpsd
    Lpsd committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    8371339 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary check

    @Lpsd
    Lpsd committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    c72f014 View commit details
    Browse the repository at this point in the history

  7. Change logic of SetStartTime

    @Lpsd
    Lpsd committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    3317800 View commit details
    Browse the repository at this point in the history

  8. Rename variable 

    Probably should refactor all this Discord code to not use Hungarian notation tbh
    @Lpsd
    Lpsd committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    fb1250e View commit details
    Browse the repository at this point in the history

  9. Swap CCore::GetSingleton usage for g_pCore

    @Lpsd
    Lpsd committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    249e65b View commit details
    Browse the repository at this point in the history

  10. Use details instead of state for server name

    @Lpsd
    Lpsd committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    488e7a1 View commit details
    Browse the repository at this point in the history

  11. Add some more default states (walking, driving, dead)

    @Lpsd
    Lpsd committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    fc9a35b View commit details
    Browse the repository at this point in the history

  12. Allow custom state to be empty in order to reset it 

    This will allow servers to revert to using the built-in/default states
    @Lpsd
    Lpsd committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    233211b View commit details
    Browse the repository at this point in the history

  13. Add setDiscordRichPresenceEndTime

    @Lpsd
    Lpsd committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    1fa482e View commit details
    Browse the repository at this point in the history

  14. Add missing OOP method for setDiscordRichPresenceEndTime

    @Lpsd
    Lpsd committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    a872851 View commit details
    Browse the repository at this point in the history

  15. Allow all string values to be empty/reset

    @Lpsd
    Lpsd committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    148fb34 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Remove unnecessary presence updates 

    We handle presence state updates primarily in CClientGame::DoPulsePostFrame() now
    @Lpsd
    Lpsd committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    b67d252 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2023

  1. Set Discord state update rate to 15

    @Lpsd
    Lpsd committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    a31499e View commit details
    Browse the repository at this point in the history

  2. Add new default states based on player tasks

    @Lpsd
    Lpsd committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    d6a27b2 View commit details
    Browse the repository at this point in the history

  3. Use std::optional in STaskState 

    Requires moving to Client Deathmatch due to Game SA not supporting C++17
    @Lpsd
    Lpsd committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    a5e70f5 View commit details
    Browse the repository at this point in the history

  4. Update CDiscordRichPresence.cpp

    @Lpsd
    Lpsd committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    f63066c View commit details
    Browse the repository at this point in the history

  5. Update BitStream check in CPacketHandler::Packet_ServerJoined

    @Lpsd
    Lpsd committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    02b1f7e View commit details
    Browse the repository at this point in the history

  6. Use unordered_multimap

    @Lpsd
    Lpsd committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    1c2c215 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Address code review

    @Lpsd
    Lpsd committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    bff9390 View commit details
    Browse the repository at this point in the history

  2. Revert GetTickCount64_ usage where unix epoch necessary

    @Lpsd
    Lpsd committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    65bc6d1 View commit details
    Browse the repository at this point in the history

  3. Addendum to previous commit

    @Lpsd
    Lpsd committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    2c79323 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Update g_vehicleTypePrefixes order

    @Lpsd
    Lpsd committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    98bd54c View commit details
    Browse the repository at this point in the history