Minor Discord-RPC updates and Crowdin integration #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I changed this method to GetTickCount() because the function was being called too frequently, which could lead to additional issues. Now it refreshes every 10 seconds, which should be sufficient. Additionally, in the Discord documentation, there is a note about a rate limit of 1 per 15 seconds, but in reality, it can sometimes be less or more. It also introduces minor improvements.
I prepared this code so that in case of issues, we can smoothly disable the IO thread in Discord-RPC. This, however, brings problems, for example, during resource retrieval, the connection can be interrupted, causing a discrepancy, which may lead to an assert error.
I've decided to use synchronization maxPlayers in player_puresync. Synchronization sends every 512 packets, which, in the default settings, is interpreted as just under a minute.
tederis
reviewed
Oct 28, 2023
|
I've added a more precise method for checking if client is connected with custom application. |
1 task
znvjder
deleted the
feature/discordrpc-crowdin-integrity-and-minor-fixes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several features and improvements:
Crowdin Integration: This feature enables the integration with Crowdin, allowing statuses to be displayed in the language used by the client. This enhances the localization of the application for users who prefer a different language.
Minor Fixes: The PR includes several minor fixes, addressing issues and bugs that have been identified and resolved for a smoother user experience.
Player Count Display: A new feature has been added that allows the display of the number of players in the status when using the default MTA Rich Presence application. This provides users with information about the current player count, which can be helpful for server management and user engagement.
Increased Rich Presence Refresh Time: The refresh time for Rich Presence has been increased. This adjustment is aimed at mitigating potential game fluidity issues, ensuring a smoother and more stable gaming experience for users.
Custom Application Handling: With the changes introduced in this PR, if a custom application is used and a resource is stopped (triggered the onClientResourceStop event), it will now trigger a reset and set the default MTA Rich Presence application. This ensures that the default Rich Presence functionality is retained when using custom applications. Additionally, a more precise method for checking if the client is connected with a custom application has been added, enhancing the reliability and accuracy of custom application detection.
Overall, this PR enhances localization, improves the user experience, and addresses potential issues related to game fluidity, resource handling, and custom application detection.