More changes for #3251 #3253
Merged
More changes for #3251 #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tederis
reviewed
Nov 28, 2023
tederis
reviewed
Nov 28, 2023
|
Committed changes from review |
tederis
reviewed
Nov 28, 2023
|
LGTM |
Dutchman101
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's possible that the player spams 100 events, but half of them are caught in one interval, and the rest in another (since the whole map gets cleared each interval). This means if your threshold is 100, it's only going to count as 50.
These changes make it so the map is processed every pulse, and each entry has its interval tracked individually. No more lost counts