Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashes caused by createBuilding with engineRequestModel #3330

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Fix crashes caused by createBuilding with engineRequestModel #3330

merged 4 commits into from
Apr 3, 2024

Conversation

TheNormalnij
Copy link
Contributor

@TheNormalnij TheNormalnij commented Mar 2, 2024 •
edited

Fixes issues:

  • Destroyed building leaves grass
  • Crash occurs when a resource that uses createBuilding with engineRequestModel is stopped.

@TheNormalnij TheNormalnij added the bugfix Solution to a bug of any kind label Mar 2, 2024
@TheNormalnij TheNormalnij added this to the 1.6.1 milestone Mar 2, 2024
TracerDS
TracerDS suggested changes Mar 4, 2024
View reviewed changes
Client/game_sa/CPtrNodeSingleListSA.h Outdated Show resolved Hide resolved
Nico8340
Nico8340 approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@Nico8340 Nico8340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheNormalnij TheNormalnij mentioned this pull request Mar 6, 2024
Closed
1 task
@TheNormalnij TheNormalnij mentioned this pull request Mar 18, 2024
Merged
@Fernando-A-Rocha
Copy link
Contributor

ready to merge? 👀

@TheNormalnij
Copy link
Contributor Author

TheNormalnij commented Mar 28, 2024 via email

@Dutchman101 Dutchman101 merged commit 6245a68 into multitheftauto:master Apr 3, 2024
6 checks passed
MTABot pushed a commit that referenced this pull request Apr 3, 2024
@github-actions
Synchronize changes from 1.6 master branch [ci skip]
98a8e1b 
6245a68 Fix crashes caused by createBuilding with engineRequestModel (#3330)
@TheNormalnij TheNormalnij deleted the TheNormalnij/building_crashes branch May 3, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lpsd Lpsd Lpsd left review comments

@TracerDS TracerDS TracerDS requested changes

@Nico8340 Nico8340 Nico8340 approved these changes

Assignees
No one assigned
Labels
bugfix Solution to a bug of any kind
Projects
None yet
Milestone
1.6.1
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@TheNormalnij @Fernando-A-Rocha @Lpsd @TracerDS @Nico8340 @Dutchman101 @Pirulax