Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postfx stage fix #3478

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Postfx stage fix #3478

merged 5 commits into from
Jun 20, 2024

Conversation

tederis
Copy link
Collaborator

@tederis tederis commented Jun 16, 2024

Fixes the bug described in #3457. This PR changes the render order in the following way:

  1. Color filter, grain, radiosity, infrared and nightvision effects are still occured before the "postfx" stage.
  2. Heat haze and CCTV effects are now rendered after the "postfx" stage.
    This is due to specifics of the bug(see dxDrawMaterialLine3D renders through buildings when heat haze is enabled and some other conditions are met #3457 (comment)).

Client/core/CCore.cpp Outdated Show resolved Hide resolved
Client/core/CCore.cpp Outdated Show resolved Hide resolved
@Dutchman101 Dutchman101 merged commit c2b75c1 into multitheftauto:master Jun 20, 2024
6 checks passed
MTABot pushed a commit that referenced this pull request Jun 20, 2024
@botder botder added this to the 1.6.1 milestone Jun 20, 2024
@botder
Copy link
Member

botder commented Jun 20, 2024

Crashes on disconnect - fixed in a7e58e0

image

@tederis
Copy link
Collaborator Author

tederis commented Jun 21, 2024

Crashes on disconnect - fixed in a7e58e0

image

Oh, I forgot about the nulling. Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Solution to a bug of any kind
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants