Fix GetCommandsBoundToKey to handle command binds without szArguments #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where szArguments is empty, the return table will be empty, even when there is a command bound to that key
|
So the null character |
|
IIRC yes. |
|
This is where I found the relevant source code to update the present code above. |
|
Nice work! Sorry for taking so long with the merge. note: the output table will still contain commands with multiple arguments. only commands with no arguments are missing from the output table. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where szArguments is empty, the return table will be empty, even when there is a command bound to that key.
Before this patch,
getCommandsBoundToKey("p")would have returned an empty table, even when the resourceadminhas a command bound to that key, which you can confirm withgetBoundKeys("admin") = { ["p"] = "down" }.