Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update col position on attach #42

Conversation

Viger74
Copy link

@Viger74 Viger74 commented May 4, 2016

Update colshape position on client when it was attached

@Necktrox
Copy link
Contributor

Necktrox commented May 4, 2016

You forgot to add spaces around brackets etc. look at the code above/below your lines.

@ccw808
Copy link
Member

ccw808 commented May 4, 2016

How does this commit impact on current behaviour?

@qaisjp qaisjp added the feedback Further information is requested label May 22, 2016
@darkdreamingdan
Copy link
Member

I can't see how this would work. It just sets the position once, and I can't see how it would work when colshapes are attached to moving elements. Moreover, there's no math here so it wont work correctly with rotating objects (e.g. trying to attach a colshape to the wheels of a car) - offsets are always absolute

@qaisjp
Copy link
Contributor

qaisjp commented Jul 23, 2016

Closing since PR author has not replied within two months.

@qaisjp qaisjp closed this Jul 23, 2016
@qaisjp qaisjp added wontfix and removed feedback Further information is requested labels Jul 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants