Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setPedArmor function for clientside peds #811

Merged
merged 7 commits into from Sep 2, 2019
Merged

Add setPedArmor function for clientside peds #811

merged 7 commits into from Sep 2, 2019

Conversation

StrixG
Copy link
Contributor

@StrixG StrixG commented Feb 11, 2019

No description provided.

@qaisjp qaisjp added the enhancement New feature or request label Feb 12, 2019
@StrixG
Copy link
Contributor Author

StrixG commented Feb 13, 2019

I will make one pull request with all missing clientside ped functions.

@StrixG StrixG closed this Feb 13, 2019
@qaisjp
Copy link
Contributor

qaisjp commented Feb 13, 2019

separate pull requests are preferred

@StrixG StrixG reopened this Feb 13, 2019
qaisjp
qaisjp previously requested changes Feb 17, 2019
View reviewed changes
Copy link
Contributor

@qaisjp qaisjp left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should return false on failure. Only getters return nil on failure.

@patrikjuvonen
Copy link
Contributor

Waiting for #821 to resolve so we can make changes accordingly.

@patrikjuvonen patrikjuvonen added this to the Backlog milestone Feb 22, 2019
@botder
Copy link
Member

botder commented Aug 17, 2019

The decision in pull request #821 (Pin down return value on failure) is now settled.

@patrikjuvonen patrikjuvonen dismissed qaisjp’s stale review August 17, 2019 15:29

Up-to-date review submitted.

patrikjuvonen
patrikjuvonen approved these changes Aug 17, 2019
View reviewed changes
Copy link
Contributor

@patrikjuvonen patrikjuvonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This PR is ready to be merged after 1.5.7 is released.

@patrikjuvonen patrikjuvonen modified the milestones: Backlog, 1.6 Aug 17, 2019
@patrikjuvonen patrikjuvonen self-assigned this Aug 17, 2019
@patrikjuvonen patrikjuvonen merged commit e1ac7e2 into multitheftauto:master Sep 2, 2019
@StrixG StrixG deleted the setPedArmor-clientside branch September 7, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrikjuvonen patrikjuvonen patrikjuvonen approved these changes

@qaisjp qaisjp qaisjp left review comments

Assignees

@patrikjuvonen patrikjuvonen

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.5.8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@StrixG @qaisjp @patrikjuvonen @botder