admin2: forward-ported permissions widget from admin1 #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial commit to forward-port admin1's permission widget to admin2
admin2: added missing SYNC definition
admin2: fixed message box type
admin2: removed redundantly passed parameters
brackets around if conditions; no space before first or after last function parameter; no space between function name and parameter brackets
aMessageBox.Show() circumvents a minor error check compared to messageBox(). I mistakenly used the latter
admin2: updated file path in head comment
jlillis
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
admin2 currently has a non-functional "Give admin" button in the players tab. Not only is it not functional, but it's also a considerable downgrade from admin1's quick player permission management. This pull request brings admin1's permission widget over to admin2.
Since admin2 is structured slightly differently and I'm not very well-versed in working with either of the resources I'm not 100% sure about whether I adjusted for those differences correctly in the places I had to, but feedback from the developer discord so far has been positive. Particularly the data transmission between server and client and refreshing the displayed data might need checking, because I hardly know how it's expected to be used correctly.