Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hedit: Add hungarian localization #465

Merged
merged 2 commits into from Feb 1, 2024
Merged

Conversation

Nico8340
Copy link
Contributor

No description provided.

@jlillis
Copy link
Contributor

jlillis commented Jan 31, 2024

Formatting checks out but do we have any other Hungarian-speaking contributors that can review for accuracy?

Copy link

@Rilot06 Rilot06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a hungarian person, I've made a "few" comments where changes would be nice to fix translations or make them more natural in hungarian. Some of them may seem nit-picky, but they make the translation better. Also, some of the translations can't be mirror translated to hungarian, some of them were probably translated by google translate in this pr, I've tried to make them more natural.

[gameplay]/hedit/client/gui/languages/hungarian.lua Outdated Show resolved Hide resolved
[gameplay]/hedit/client/gui/languages/hungarian.lua Outdated Show resolved Hide resolved
[gameplay]/hedit/client/gui/languages/hungarian.lua Outdated Show resolved Hide resolved
[gameplay]/hedit/client/gui/languages/hungarian.lua Outdated Show resolved Hide resolved
[gameplay]/hedit/client/gui/languages/hungarian.lua Outdated Show resolved Hide resolved
[gameplay]/hedit/client/gui/languages/hungarian.lua Outdated Show resolved Hide resolved
[gameplay]/hedit/client/gui/languages/hungarian.lua Outdated Show resolved Hide resolved
[gameplay]/hedit/client/gui/languages/hungarian.lua Outdated Show resolved Hide resolved
[gameplay]/hedit/client/gui/languages/hungarian.lua Outdated Show resolved Hide resolved
[gameplay]/hedit/client/gui/languages/hungarian.lua Outdated Show resolved Hide resolved
@Nico8340
Copy link
Contributor Author

Thanks for the review, I'll start working on the fixes soon. I will update everything in one commit, for the sake of transparency, so don't be surprised if the conversation is resolved, but there is no commit yet.

@Nico8340 Nico8340 marked this pull request as draft January 31, 2024 15:50
@Nico8340 Nico8340 marked this pull request as ready for review January 31, 2024 16:16
Copy link

@Rilot06 Rilot06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything I've commented about was fixed. @Nico8340 messaged me on Discord, and by mutual agreement we've changed a few lines where my proposed translation didn't fit in the GUI.

@Dutchman101 Dutchman101 merged commit 53050dd into multitheftauto:master Feb 1, 2024
1 check passed
@Nico8340 Nico8340 deleted the hedit branch February 2, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants