Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for token accounts assets #1114

Merged

Conversation

cfaur09
Copy link
Contributor

@cfaur09 cfaur09 commented Aug 30, 2023

Reasoning

  • For tokens/:token/accounts, for each account, the assets field is missing

Proposed Changes

  • Adding the assets field for each account that owns a specific token

How to test

  • /tokens/WEGLD-bd4d79/accounts -> every account should contain assets field
  • tokens/BHAT-c1fde3/accounts -> if an account does not have assets defined, the assets field will not be displayed

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (c427d6c) 64.58% compared to head (4f35911) 64.58%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1114      +/-   ##
===============================================
- Coverage        64.58%   64.58%   -0.01%     
===============================================
  Files              577      577              
  Lines            15022    15026       +4     
  Branches          1550     1550              
===============================================
+ Hits              9702     9704       +2     
- Misses            3962     3965       +3     
+ Partials          1358     1357       -1     
Flag Coverage Δ
integrationtests 64.44% <100.00%> (-0.01%) ⬇️
unittests 33.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/endpoints/tokens/entities/token.account.ts 100.00% <100.00%> (ø)
src/endpoints/tokens/token.service.ts 45.78% <100.00%> (+0.14%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cfaur09 cfaur09 merged commit 96478fb into development Aug 30, 2023
6 of 7 checks passed
@cfaur09 cfaur09 deleted the SERVICES-1805-add-support-for-token-accounts-assets branch August 30, 2023 08:11
@cfaur09 cfaur09 added feature New feature or request test Create or update unit / integration tests labels Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request test Create or update unit / integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants