Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add token timestamp #1120

Merged
merged 1 commit into from Sep 19, 2023
Merged

Conversation

cfaur09
Copy link
Contributor

@cfaur09 cfaur09 commented Sep 18, 2023

Reasoning

  • For all fungible tokens, creation date field was not defined

Proposed Changes

  • Fetch timestamp value from ES for every fungible token

How to test

  • /tokens -> all tokens should have timestamp field defined
  • /accounts/erd1awuuva7dhnlun9huwx7uefwpkhzjx9d3phenujgkv3zvx9tvsatsw420qt/tokens/UTK-2f80e9 -> returned token should have timestamp field defined
  • /accounts/erd1kc3y0d3jhmv4j42lvyq84t395s7s47tucpw97grwgaj8dqlkzumsw97k34/roles/tokens -> returned token should have timestamp field defined
  • /accounts/erd1kc3y0d3jhmv4j42lvyq84t395s7s47tucpw97grwgaj8dqlkzumsw97k34/roles/tokens/UTK-2f80e9 -> returned token should have timestamp field defined

@cfaur09 cfaur09 added the feature New feature or request label Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.15% ⚠️

Comparison is base (7fdecb9) 64.62% compared to head (4b63aa9) 64.48%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1120      +/-   ##
===============================================
- Coverage        64.62%   64.48%   -0.15%     
===============================================
  Files              579      579              
  Lines            15131    15133       +2     
  Branches          1569     1569              
===============================================
- Hits              9779     9759      -20     
- Misses            3982     4002      +20     
- Partials          1370     1372       +2     
Flag Coverage Δ
integrationtests 64.35% <100.00%> (-0.15%) ⬇️
unittests 33.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../common/indexer/elastic/elastic.indexer.service.ts 61.31% <ø> (ø)
src/endpoints/esdt/esdt.service.ts 46.15% <ø> (ø)
src/endpoints/tokens/entities/token.properties.ts 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanghel tanghel merged commit 7be61c6 into development Sep 19, 2023
6 of 7 checks passed
@tanghel tanghel deleted the SERVICES-1844-add-token-timestamp-field branch September 19, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants