Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SDK Nestjs to latest version #986

Merged
merged 3 commits into from Feb 28, 2023
Merged

Update SDK Nestjs to latest version #986

merged 3 commits into from Feb 28, 2023

Conversation

tanghel
Copy link
Contributor

@tanghel tanghel commented Feb 28, 2023 •
edited

Reasoning

  • executing /accounts/:account?fields=address, then /accounts?fields=balance does not return any data
  • executing /accounts?fields=address&extract=address crashes the API completely

Proposed Changes

  • Update SDK Nestjs to latest version, which contains a very important bugfix for the fields interceptor

How to test

  • executing /accounts?fields=address, then /accounts?fields=balance should return data for both calls
  • executing /accounts/:account?fields=address&extract=address should not crash the API

@tanghel tanghel added the bugfix Fix something that isn't working correctly label Feb 28, 2023
@tanghel tanghel merged commit a0b50a4 into main Feb 28, 2023
@tanghel tanghel deleted the SERVICES-1369-update-sdk-nestjs-to-latest-version branch February 28, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielmatei gabrielmatei gabrielmatei approved these changes

@cfaur09 cfaur09 cfaur09 approved these changes

Assignees
No one assigned
Labels
bugfix Fix something that isn't working correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tanghel @gabrielmatei @cfaur09