Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added remove code leaf builin func name #267

Open
wants to merge 7 commits into
base: feat/remove-code-leaf
Choose a base branch
from

Conversation

ssd04
Copy link
Contributor

@ssd04 ssd04 commented Oct 11, 2023

No description provided.

@ssd04 ssd04 self-assigned this Oct 11, 2023
@ssd04 ssd04 marked this pull request as ready for review October 12, 2023 07:56
@@ -68,6 +68,7 @@ type Throttler interface {
type KeyValueHolder interface {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we target the branch towards a feat branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


// WithoutCodeLeaf is used for account with code, it specifies that the trie code leaf has been moved to storage,
// it is enabled only after the activation of MigrateCodeLeafEnableEpoch flag
WithoutCodeLeaf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all nodes with version "without code leaf" are assumed to be also with auto balance enabled right?

Just to confirm, it would not be possible to move from NotSpecified directly to WithoutCodeLeaf right?
If this is the case we should take care of the testing process to allow enough time (and actively do the first migration - auto balance) before this and ensure everything is migrated to auto balance before, or directly start with AutoBalanceEnabled active.

Also would this version change affect the logic for auto balancing since the version will be different but auto balancing will still need to be done? (I am asking here if there are checks in the code for the specific AutoBalanceEnabled version)

@ssd04 ssd04 changed the base branch from rc/v1.7.0 to feat/remove-code-leaf December 13, 2023 14:30
@ssd04 ssd04 dismissed BeniaminDrasovean’s stale review December 13, 2023 14:30

The base branch was changed.

AdoAdoAdo
AdoAdoAdo previously approved these changes Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants