Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consensus separation - common components #85

Draft
wants to merge 13 commits into
base: feat/consensus-separation
Choose a base branch
from

Conversation

ssd04
Copy link
Contributor

@ssd04 ssd04 commented Aug 11, 2022

Moved several interfaces and constants from elrond-go to core:

  • moved IsContextDone to core
  • constants for block processing state and node state
  • interfaces for p2p message, validator, epoch start action handler

@ssd04 ssd04 self-assigned this Aug 11, 2022
Copy link
Contributor

@AdoAdoAdo AdoAdoAdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please re-target the PR to a feat branch

@ssd04 ssd04 changed the base branch from rc/2022-july to feat/consensus-separation August 12, 2022 09:20
@iulianpascalau iulianpascalau self-requested a review August 30, 2022 06:53
IsInterfaceNil() bool
}

// InterceptedDebugger defines an interface for debugging the intercepted data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mixed feelings about declaring this interface here. Also, for the Iterceptor and EpochStartActionHandler as they do not quite define the core business logic of elrond-go.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remain as it is, for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants