EN-6373 : add test for ComputeEndOfEpochEconomics #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
miiu96
commented
May 8, 2020
•
miiu96
commented
- Add a test that verify if end of epoch economics data) is calculated as expected.
sasurobert
requested changes
May 8, 2020
| } | ||
|
|
||
| rewardsPerBlock, _ := big.NewInt(0).SetString("84559445290038908043", 10) // *based on 0.1 inflation | ||
| for _, input := range testInpus { |
There was a problem hiding this comment.
make a separate function which gets one input and does verifications.
| TimeDurationCalled: func() time.Duration { | ||
| return time.Duration(roundDur) * time.Second | ||
| }, | ||
| } |
There was a problem hiding this comment.
may create a function of setup.
| devFeesInEpoch *big.Int | ||
| } | ||
|
|
||
| testInpus := []testInput{ |
| totalSupply, _ := big.NewInt(0).SetString("20000000000000000000000000000", 10) // 20 Billions ERD | ||
| nodePrice, _ := big.NewInt(0).SetString("1000000000000000000000", 10) // 1000 ERD | ||
|
|
||
| roundDur := 4 |
| roundsPerEpoch := uint64(epochDuration / roundDur) | ||
| type testInput struct { | ||
| blockPerEpochOneShard uint64 | ||
| acFeesInEpoch *big.Int |
There was a problem hiding this comment.
What is ac ? actual? rename it to be better understood
| economicsBlock, err := ec.ComputeEndOfEpochEconomics(meta) | ||
| assert.Nil(t, err) | ||
|
|
||
| blocksPerEpochTotal := int64(input.blockPerEpochOneShard * 3) |
There was a problem hiding this comment.
totalBlocksPerEpoch
sasurobert
approved these changes
May 13, 2020
SebastianMarian
approved these changes
May 13, 2020
AdoAdoAdo
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.