Fix minor issue and add the GENESIS_DELAY option #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
previously approved these changes
May 12, 2020
process/smartContract/process.go
Outdated
| @@ -540,7 +540,8 @@ func (sc *scProcessor) DeploySmartContract( | |||
|
|
|||
| func (sc *scProcessor) printScDeployed(vmOutput *vmcommon.VMOutput, tx data.TransactionHandler) { | |||
| scGenerated := make([]string, 0, len(vmOutput.OutputAccounts)) | |||
| for addr := range vmOutput.OutputAccounts { | |||
| for key := range vmOutput.OutputAccounts { | |||
There was a problem hiding this comment.
suggestion to change to:
for _, account := range vmOutput.OutputAccounts {
if check.IfNil(account){
continue
}
......🥇 for finding this
There was a problem hiding this comment.
Changed to check account == nil.
| @@ -76,7 +76,7 @@ updateNodeConfig() { | |||
|
|
|||
| cp nodesSetup.json nodesSetup_edit.json | |||
|
|
|||
| let startTime="$(date +%s) + $NODE_DELAY + 30" | |||
| let startTime="$(date +%s) + $GENESIS_DELAY" | |||
iulianpascalau
previously approved these changes
May 13, 2020
andreibancioiu
previously approved these changes
May 13, 2020
camilbancioiu
dismissed stale reviews from andreibancioiu and iulianpascalau
via
0a796a8
iulianpascalau
approved these changes
May 13, 2020
andreibancioiu
approved these changes
May 13, 2020
LucianMincu
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following changes:
$GENESIS_DELAYoption in the testnet scripts, which specifies how far into the future is the genesis moment for the started testnet, calculated from the moment the testnet is started (withstart.sh). Expressed in seconds.