Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor issue and add the GENESIS_DELAY option #1725

Merged
merged 9 commits into from
May 13, 2020

Conversation

camilbancioiu
Copy link
Contributor

This PR adds the following changes:

  • added the $GENESIS_DELAY option in the testnet scripts, which specifies how far into the future is the genesis moment for the started testnet, calculated from the moment the testnet is started (with start.sh). Expressed in seconds.
  • fixed a minor issue with displaying the address(es) of the deployed SmartContracts

andreibancioiu
andreibancioiu previously approved these changes May 12, 2020
@@ -540,7 +540,8 @@ func (sc *scProcessor) DeploySmartContract(

func (sc *scProcessor) printScDeployed(vmOutput *vmcommon.VMOutput, tx data.TransactionHandler) {
scGenerated := make([]string, 0, len(vmOutput.OutputAccounts))
for addr := range vmOutput.OutputAccounts {
for key := range vmOutput.OutputAccounts {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion to change to:

for _, account := range vmOutput.OutputAccounts {
    if check.IfNil(account){
        continue
    }
    ......

🥇 for finding this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to check account == nil.

@@ -76,7 +76,7 @@ updateNodeConfig() {

cp nodesSetup.json nodesSetup_edit.json

let startTime="$(date +%s) + $NODE_DELAY + 30"
let startTime="$(date +%s) + $GENESIS_DELAY"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

iulianpascalau
iulianpascalau previously approved these changes May 13, 2020
andreibancioiu
andreibancioiu previously approved these changes May 13, 2020
@LucianMincu LucianMincu merged commit 63f16bf into development May 13, 2020
@LucianMincu LucianMincu deleted the minor-fixes-scripts-trace branch May 13, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants