-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minor issue and add the GENESIS_DELAY option #1725
Conversation
process/smartContract/process.go
Outdated
@@ -540,7 +540,8 @@ func (sc *scProcessor) DeploySmartContract( | |||
|
|||
func (sc *scProcessor) printScDeployed(vmOutput *vmcommon.VMOutput, tx data.TransactionHandler) { | |||
scGenerated := make([]string, 0, len(vmOutput.OutputAccounts)) | |||
for addr := range vmOutput.OutputAccounts { | |||
for key := range vmOutput.OutputAccounts { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion to change to:
for _, account := range vmOutput.OutputAccounts {
if check.IfNil(account){
continue
}
......
🥇 for finding this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to check account == nil
.
@@ -76,7 +76,7 @@ updateNodeConfig() { | |||
|
|||
cp nodesSetup.json nodesSetup_edit.json | |||
|
|||
let startTime="$(date +%s) + $NODE_DELAY + 30" | |||
let startTime="$(date +%s) + $GENESIS_DELAY" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
0a796a8
This PR adds the following changes:
$GENESIS_DELAY
option in the testnet scripts, which specifies how far into the future is the genesis moment for the started testnet, calculated from the moment the testnet is started (withstart.sh
). Expressed in seconds.