Implement go routines closing mechanism #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SebastianMarian
commented
May 13, 2020
•
SebastianMarian
commented
- Added go routines close mechanism through context and io.Close implementation for components: Chronology, Worker, SyncTimer, Bootstrapper, epochStartTrigger, miniBlocksPoolsCleaner, txsPoolsCleaner
…ementation for components: Chronology, Worker, SyncTimer, Bootstrapper
sasurobert
reviewed
May 14, 2020
consensus/spos/interface.go
Outdated
| @@ -96,6 +98,7 @@ type SubroundsFactory interface { | |||
|
|
|||
| //WorkerHandler represents the interface for the SposWorker | |||
| type WorkerHandler interface { | |||
| io.Closer | |||
There was a problem hiding this comment.
shouldn't we use our own interface ? instead of io.Closer
There was a problem hiding this comment.
yep, removed it from all modified interfaces
…entation for components: epochStartTrigger, txsPoolsCleaner, miniBlocksPoolsCleaner
…d checkChannels from Worker
SebastianMarian
changed the title
sasurobert
approved these changes
May 15, 2020
AdoAdoAdo
approved these changes
May 15, 2020
LucianMincu
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.