get rewards txs from pool before commitEpochStart method #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also modify gasUsed now is measured in gas units
bogdan-rosianu
approved these changes
May 14, 2020
sasurobert
approved these changes
May 14, 2020
|
|
||
| tx.GasUsed = gasUsed.String() | ||
| tx.GasUsed = gasUsed.Uint64() |
There was a problem hiding this comment.
gasUsed for normal transactions can be computed via ComputeGasLimit(tx) txFeeHandler
LucianMincu
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix : rewards transactions was not indexed anymore because method that gets rewards transactions from pool was called after transactions was removed from pool.
FIX : call the method that reads the transactions before they are removed from the pool
Also the field 'gasUsed' of structure Transaction that is saved in elasticsearch database is now calculated in gas units. To convert the field 'gasUsed' in ERD must by multiply with gas price.