Add consensus originator check #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iulianpascalau
commented
Jun 21, 2020
iulianpascalau
commented
- added peer id in consensus message as to not allow impersonating. Anyone caught sending a consensus message that won't contain its originator peer id will be subject to peer banning.
…nyone caught sending a consensus message that won't contain its originator peer id will be subject to peer banning.
…nsensus-originator-check
andreibancioiu
previously approved these changes
Jun 21, 2020
heartbeat/data/proto/heartbeat.proto
Outdated
| @@ -31,7 +31,7 @@ message HeartbeatDTO { | |||
| string PeerType = 11; | |||
| string Identity = 12; | |||
| bool IsValidator = 13; | |||
| int64 LastUptimeDowntime = 14; | |||
| int64 LastUptimeDowntime = 14; | |||
There was a problem hiding this comment.
Indentation is not correct.
There was a problem hiding this comment.
:( will fix that. Gofmt does not run automatically for .proto files
| @@ -83,6 +84,12 @@ func (wrk *Worker) checkConsensusMessageValidity(cnsMsg *consensus.Message) erro | |||
| err.Error()) | |||
| } | |||
|
|
|||
| cnsMsgOriginator := core.PeerID(cnsMsg.OriginatorPid) | |||
| if cnsMsgOriginator != originator { | |||
sasurobert
previously approved these changes
Jun 22, 2020
Base automatically changed from
add-feedback-for-peer-honesty-in-consensus
to
release-candidate
June 22, 2020 14:22
LucianMincu
dismissed stale reviews from sasurobert and andreibancioiu
The base branch was changed.
andreibancioiu
approved these changes
Jun 22, 2020
sasurobert
approved these changes
Jun 22, 2020
LucianMincu
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.