-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consensus: fix deadlock #2027
consensus: fix deadlock #2027
Conversation
if bmm.PrepareBroadcastHeaderValidatorCalled != nil { | ||
return bmm.PrepareBroadcastHeaderValidatorCalled( | ||
_ = bmm.PrepareBroadcastHeaderValidatorCalled( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change called function to not return err
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
dbb.delayedBroadcastData = dbb.delayedBroadcastData[i+1:] | ||
return | ||
break OuterLoop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a first. Can we refactor this? Maybe split in another function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might change the break OuterLoop
line one day
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System tests passed.
Fixing deadlock when setting alarms for delayed broadcast data.