EN-8010/ESDT-ticker-and-name #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vm/errors.go
Outdated
| @@ -170,6 +167,12 @@ var ErrInvalidMaxNumberOfNodes = errors.New("invalid number of max number of nod | |||
| // ErrTokenNameNotHumanReadable signals that token name is not human readable | |||
| var ErrTokenNameNotHumanReadable = errors.New("token name is not human readable") | |||
|
|
|||
| // ErrTickerNameNotValid signals that ticker name is not valid | |||
| var ErrTickerNameNotValid = errors.New("token name is not valid") | |||
There was a problem hiding this comment.
ticker name is not valid
vm/errors.go
Outdated
| var ErrTickerNameNotValid = errors.New("token name is not valid") | ||
|
|
||
| // ErrCouldNotCreateNewIdentifier signals that token identifier could not be created | ||
| var ErrCouldNotCreateNewIdentifier = errors.New("token identifier could not be created") |
There was a problem hiding this comment.
ErrCouldNotCreateNewTokenIdentifier or ErrCouldNotCreateTokenIdentifier
SebastianMarian
previously approved these changes
Nov 11, 2020
raduchis
requested changes
Nov 11, 2020
| @@ -174,7 +174,7 @@ func TestEsdt_ExecuteIssue(t *testing.T) { | |||
| assert.Equal(t, vmcommon.Ok, output) | |||
|
|
|||
| assert.Equal(t, 1, len(eei.output)) | |||
| assert.Equal(t, []byte("01234567891"), eei.output[0]) | |||
| assert.Equal(t, tokenID, eei.output[0]) | |||
There was a problem hiding this comment.
the check for initial supply would also help here
There was a problem hiding this comment.
there are other unit tests for this.
raduchis
previously approved these changes
Nov 12, 2020
vm/errors.go
Outdated
| @@ -176,7 +176,7 @@ var ErrCouldNotCreateNewTokenIdentifier = errors.New("token identifier could not | |||
| // ErrBLSPublicKeyAlreadyJailed signals that bls public key was already jailed | |||
| var ErrBLSPublicKeyAlreadyJailed = errors.New("bls public key already jailed") | |||
|
|
|||
| // ErrInvalidEndOfEpochAccessAddress signals that end of epoch access address is invalid | |||
| // ErrInvalidEndOfEpochAccessAddress signals that end of epoch access address is invalidgetExistingToken | |||
There was a problem hiding this comment.
Delete getExistingToken from the end of the comment
vm/errors.go
Outdated
| @@ -185,8 +185,8 @@ var ErrNilChanceComputer = errors.New("nil chance computer") | |||
| // ErrNilEpochNotifier signals that the provided EpochNotifier is nil | |||
| var ErrNilEpochNotifier = errors.New("nil EpochNotifier") | |||
|
|
|||
| // ErrNoTokenWithGivenName signals that token does not exists with given name | |||
| var ErrNoTokenWithGivenName = errors.New("no token with given name") | |||
| // ErrNoTickerWithGivenName signals that token does not exists with given name | |||
There was a problem hiding this comment.
"ticker does not exist" instead "token does not exists"
vm/errors.go
Outdated
| // ErrNoTokenWithGivenName signals that token does not exists with given name | ||
| var ErrNoTokenWithGivenName = errors.New("no token with given name") | ||
| // ErrNoTickerWithGivenName signals that token does not exists with given name | ||
| var ErrNoTickerWithGivenName = errors.New("no token with given name") |
There was a problem hiding this comment.
"no ticker" instead "no token"
raduchis
previously approved these changes
Nov 13, 2020
SebastianMarian
previously approved these changes
Nov 13, 2020
sasurobert
dismissed stale reviews from SebastianMarian and raduchis
via
3964fab
raduchis
approved these changes
Nov 14, 2020
SebastianMarian
approved these changes
Nov 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented ESDT ticker and creation of new identifier