EN-8343-optimize-trie-sync #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
reviewed
Nov 27, 2020
| @@ -100,11 +100,6 @@ func (ts *trieSyncer) StartSyncing(rootHash []byte, ctx context.Context) error { | |||
|
|
|||
| numUnResolved := ts.requestNodes() | |||
| if !shouldRetryAfterRequest && numUnResolved == 0 { | |||
| err = ts.trie.Commit() | |||
There was a problem hiding this comment.
why delete this ? isn't it better to have the final commit done ?
There was a problem hiding this comment.
If we commit here, the whole trie will be loaded again from storage. The current approach is to commit each node as it is synced.
| } | ||
|
|
||
| ts.trie.root = collapsedRoot | ||
| ts.rootFound = true |
There was a problem hiding this comment.
so we set root only after finding all its childs ?
There was a problem hiding this comment.
Yes, it should have no impact upon the functioning of the algorithm.
sasurobert
approved these changes
Nov 27, 2020
iulianpascalau
approved these changes
Nov 27, 2020
iulianpascalau
added
type:bug
LucianMincu
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of keeping the whole trie in memory during the syncing process, and Commit() the trie when it is fully synced, only keep the collapsed root and commit each node individually as it is synced.