Added session.info and -working-directory #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
previously approved these changes
Jul 7, 2019
iulianpascalau
previously approved these changes
Jul 7, 2019
added session.info txt
…windows' into bug/EN-2845-Create-directory-on-windows
iulianpascalau
requested changes
Jul 8, 2019
sasurobert
requested changes
Jul 8, 2019
cmd/node/main.go
Outdated
| @@ -173,8 +178,14 @@ VERSION: | |||
| Value: math.MaxUint32, | |||
| } | |||
|
|
|||
| //TODO remove uniqueID | |||
| uniqueID = "" | |||
| wd, _ = os.Getwd() | |||
There was a problem hiding this comment.
really don't know how to do that... it's in the var declaration...
There was a problem hiding this comment.
moved to main method
Closed
iulianpascalau
previously approved these changes
Jul 9, 2019
sasurobert
previously approved these changes
Jul 9, 2019
session.info moved to currentdir/logs
iulianpascalau
requested changes
Jul 9, 2019
cmd/node/main.go
Outdated
| os.MkdirAll(workingDir, os.ModePerm) | ||
| logDirectory := filepath.Join(workingDir, defaultLogPath) | ||
|
|
||
| os.MkdirAll(logDirectory, os.ModePerm) |
sasurobert
previously approved these changes
Jul 9, 2019
iulianpascalau
approved these changes
Jul 9, 2019
raduchis
changed the title
sasurobert
approved these changes
Jul 9, 2019
SebastianMarian
pushed a commit
that referenced
this pull request
Jul 9, 2019
* Added --working-directory and subfolders DB, logs, stats added session.info txt * Updated shardId for metachain session.info moved to currentdir/logs * Handled error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed home dependency for the directory where the storage is saved. Now they work in the current directory