Trie sync fixes #2570
Merged
Trie sync fixes #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- made the trie syncer search in the trie database before requesting missing trie nodes
iulianpascalau
added
type:bug
BeniaminDrasovean
previously approved these changes
Dec 9, 2020
AdoAdoAdo
previously approved these changes
Dec 9, 2020
sasurobert
requested changes
Dec 9, 2020
iulianpascalau
dismissed stale reviews from AdoAdoAdo and BeniaminDrasovean
via
663b8ed
sasurobert
previously approved these changes
Dec 9, 2020
BeniaminDrasovean
previously approved these changes
Dec 9, 2020
| @@ -90,3 +90,9 @@ var ErrInvalidLevelValue = errors.New("invalid trie level in memory value") | |||
|
|
|||
| // ErrNilTrieSyncStatistics signals that a nil trie sync statistics handler was provided | |||
| var ErrNilTrieSyncStatistics = errors.New("nil trie sync statistics handler") | |||
|
|
|||
| // ErrContextClosing signals that the parent context requested the closing of its children | |||
There was a problem hiding this comment.
children of the corn :)
| log.Trace("trie node intercepted", "hash", hash) | ||
|
|
||
| n, ok := ts.nodesForTrie[string(hash)] | ||
| if !ok || n.received { |
There was a problem hiding this comment.
This condition is ok?
There was a problem hiding this comment.
it was moved from the sync.go file. Used only in unit tests. Guess it is ok as the node is ignored if it does not exists or already received
| } | ||
| err = existingNode.setHash() | ||
| if err != nil { | ||
| return nil, ErrNodeNotFound |
There was a problem hiding this comment.
deliberately returned as ErrNodeNotFound because that will trigger a request (for some reason the node's hash was not computed)
data/trie/sync_test.go
Outdated
| t.Parallel() | ||
|
|
||
| timeout := time.Second * 200 | ||
| marsh, hasher := getTestMarshAndHasher() |
There was a problem hiding this comment.
marsh sounds weird, also in the method name
iulianpascalau
dismissed stale reviews from BeniaminDrasovean and sasurobert
via
992ff8a
SebastianMarian
previously approved these changes
Dec 9, 2020
BeniaminDrasovean
previously approved these changes
Dec 9, 2020
sasurobert
previously approved these changes
Dec 9, 2020
iulianpascalau
dismissed stale reviews from sasurobert, BeniaminDrasovean, and SebastianMarian
via
ba1f222
AdoAdoAdo
approved these changes
Dec 9, 2020
BeniaminDrasovean
approved these changes
Dec 9, 2020
SebastianMarian
approved these changes
Dec 9, 2020
LucianMincu
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 2 fixes that will further improve trie synchronization when the node is in the bootstrap process