Fixed backwards compatibility issues on genesis #2612

iulianpascalau · 2020-12-18T22:16:36Z

fixed a bug when saving validator data in validatorSaveLoad.go
fixed the situation when the genesis process constructs the system SC container that will lead into creating more accounts than expected on metachain
fixed a receipt bug related to gas consumption
fixed a backwards compatibility issue related to maximum allowed gas consumption of a transaction
made the developer rewards fully backwards compatible by having the old code into a new file
turned off the consensus watchdog when running in import-db mode

Testing procedures: start the import-db process, should sync every block produced on the mainnet.

- fixed the situation when the genesis process constructs the system SC container that will lead into creating more accounts than expected

- turned off the consensus watchdog when running in import-db mode

…s consumption of a transaction

SebastianMarian · 2020-12-19T22:05:12Z

genesis/process/shardGenesisBlockCreator.go

+func createGenesisConfig() config.GeneralSettingsConfig {
+	return config.GeneralSettingsConfig{
+		BuiltInFunctionsEnableEpoch:            0,
+		SCDeployEnableEpoch:                    unreachableEpoch,


So, scDeployEnableEpoch was modified from 0 to unreachableEpoch because was introduced also the genesisProcessing condition ?

Exactly. This was done as to not activate the gas computation changes that now depend on the same flag.

SebastianMarian · 2020-12-19T22:09:42Z

integrationTests/testProcessorNode.go

+	log.LogIfError(err)
+}
+
+//TODO remove functions initDelegationManager, processSCOutputAccounts, getUserAccount when TODO from L1368 is done


Maybe you should replace "L1368" with "initMetaInnerProcessors" as this line is already L1370 :)

yes - this could be moved inside initMetaInnerProcessors.

SebastianMarian · 2020-12-19T22:14:29Z

node/node.go

@@ -237,6 +238,11 @@ func (n *Node) StartConsensus() error {
 			"it is incompatible with the indexing process.")
 		n.watchdog = &watchdog.DisabledWatchdog{}
 	}
+	if !n.isInImportMode {


if n.isInImportMode instead if !n.isInImportMode

right, changed

SebastianMarian · 2020-12-19T22:28:20Z

vm/systemSmartContracts/validatorSaveLoad.go

@@ -128,7 +128,7 @@ func (v *validatorSC) saveRegistrationData(key []byte, validator *ValidatorDataV
 }

 func (v *validatorSC) saveRegistrationDataV1(key []byte, validator *ValidatorDataV2) error {
-	validatorDataV1 := &ValidatorDataV2{
+	validatorDataV1 := &ValidatorDataV1{


…sis' into fix-backwards-compatibility-genesis

integrationTests/testProcessorNode.go

genesis/process/shardGenesisBlockCreator.go

sasurobert · 2020-12-21T07:41:28Z

integrationTests/testProcessorNode.go

+	log.LogIfError(err)
+}
+
+//TODO remove functions initDelegationManager, processSCOutputAccounts, getUserAccount when TODO from L1368 is done


yes - this could be moved inside initMetaInnerProcessors.

process/factory/metachain/vmContainerFactory.go

process/smartContract/process.go

vm/factory/systemSCFactory.go

sasurobert · 2020-12-21T09:01:58Z

process/factory/metachain/vmContainerFactory.go

@@ -127,7 +127,24 @@ func (vmf *vmContainerFactory) Create() (process.VirtualMachinesContainer, error
 	return container, nil
 }

-func (vmf *vmContainerFactory) createSystemVM() (vmcommon.VMExecutionHandler, error) {
+// CreateForGenesis sets up all the needed virtual machines returning a container of all the VMs to be used in the genesis process


add comment that genesis contains only a,b,c and d contracts

SebastianMarian · 2020-12-21T09:11:20Z

process/smartContract/process.go

-		}
+	err = sc.updateDeveloperRewardsProxy(tx, vmOutput, builtInFuncGasUsed)
+	if err != nil {
+		log.Error("updateDeveloper rewards error", "error", err.Error())


To avoid printing twice the word "error" you can replace this line with:
log.Error("updateDeveloperRewardsProxy", "error", err.Error())

SebastianMarian · 2020-12-21T09:11:34Z

process/smartContract/process.go

-		}
+	err = sc.updateDeveloperRewardsProxy(tx, vmOutput, 0)
+	if err != nil {
+		log.Debug("updateDeveloper rewards error", "error", err.Error())


To avoid printing twice the word "error" you can replace this line with:
log.Error("updateDeveloperRewardsProxy", "error", err.Error())

SebastianMarian · 2020-12-21T09:12:27Z

process/smartContract/process.go

+) error {
+	if !sc.flagDeploy.IsSet() {
+		return sc.updateDeveloperRewardsV1(tx, vmOutput, builtInFuncGasUsed)
+	} else {


You can remove else branch and return directly V2

right, done

LucianMincu

Import-DB passed ✅

iulianpascalau added 2 commits December 18, 2020 20:06

- fixed a bug when saving validator data in validatorSaveLoad.go

895f9a3

- fixed the situation when the genesis process constructs the system SC container that will lead into creating more accounts than expected

- finished first integration of the fix

8413474

iulianpascalau marked this pull request as draft December 18, 2020 22:16

iulianpascalau and others added 4 commits December 19, 2020 00:17

Merge branch 'development' into fix-backwards-compatibility-genesis

fcf5c56

- fixed a receipt bug related to gas consumption

8092a44

- turned off the consensus watchdog when running in import-db mode

Merge branch 'development' into fix-backwards-compatibility-genesis

c488d27

- fixed a backwards compatibility issue related to maximum allowed ga…

f8e25b5

…s consumption of a transaction

iulianpascalau marked this pull request as ready for review December 19, 2020 21:44

SebastianMarian reviewed Dec 19, 2020

View reviewed changes

iulianpascalau added 4 commits December 20, 2020 15:58

- fixed a wrong condition for the watchdog initialization

588a62b

- made the developer rewards fully backwards compatible

987b0c1

Merge remote-tracking branch 'origin/fix-backwards-compatibility-gene…

464a2bc

…sis' into fix-backwards-compatibility-genesis

- moved the backwards compatibility code into a new file

15c4e3e

sasurobert self-requested a review December 21, 2020 07:32

sasurobert requested changes Dec 21, 2020

View reviewed changes

- fix after review

d54420b

sasurobert requested changes Dec 21, 2020

View reviewed changes

SebastianMarian reviewed Dec 21, 2020

View reviewed changes

iulianpascalau added 2 commits December 21, 2020 11:13

- added more info in comment

7548fa0

- fix after review

164e4a2

sasurobert approved these changes Dec 21, 2020

View reviewed changes

SebastianMarian approved these changes Dec 21, 2020

View reviewed changes

LucianMincu approved these changes Dec 21, 2020

View reviewed changes

LucianMincu merged commit 3a2a281 into development Dec 21, 2020

iulianpascalau deleted the fix-backwards-compatibility-genesis branch December 25, 2020 14:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed backwards compatibility issues on genesis #2612

Fixed backwards compatibility issues on genesis #2612

iulianpascalau commented Dec 18, 2020 •

edited

SebastianMarian Dec 19, 2020 •

edited

iulianpascalau Dec 20, 2020

SebastianMarian Dec 19, 2020 •

edited

sasurobert Dec 21, 2020

iulianpascalau Dec 21, 2020

SebastianMarian Dec 19, 2020

iulianpascalau Dec 20, 2020

SebastianMarian Dec 19, 2020

sasurobert Dec 21, 2020

sasurobert Dec 21, 2020

iulianpascalau Dec 21, 2020

SebastianMarian Dec 21, 2020

iulianpascalau Dec 21, 2020

SebastianMarian Dec 21, 2020

iulianpascalau Dec 21, 2020

SebastianMarian Dec 21, 2020

iulianpascalau Dec 21, 2020

LucianMincu left a comment

Fixed backwards compatibility issues on genesis #2612

Fixed backwards compatibility issues on genesis #2612

Conversation

iulianpascalau commented Dec 18, 2020 • edited

SebastianMarian Dec 19, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SebastianMarian Dec 19, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LucianMincu left a comment

Choose a reason for hiding this comment

iulianpascalau commented Dec 18, 2020 •

edited

SebastianMarian Dec 19, 2020 •

edited

SebastianMarian Dec 19, 2020 •

edited