New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix token name length condition #2618
Fix token name length condition #2618
Conversation
SebastianMarian
commented
Dec 22, 2020
- Fixed token name length condition on ESDT issuance
vm/systemSmartContracts/esdt.go
Outdated
@@ -191,7 +191,7 @@ func (e *esdt) issue(args *vmcommon.ContractCallInput) vmcommon.ReturnCode { | |||
e.eei.AddReturnMessage(err.Error()) | |||
return vmcommon.UserError | |||
} | |||
if len(args.Arguments[0]) < minLengthForTickerName || | |||
if len(args.Arguments[0]) < int(esdtConfig.MinTokenNameLength) || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need for no min length check.
vm/systemSmartContracts/esdt.go
Outdated
@@ -191,7 +191,7 @@ func (e *esdt) issue(args *vmcommon.ContractCallInput) vmcommon.ReturnCode { | |||
e.eei.AddReturnMessage(err.Error()) | |||
return vmcommon.UserError | |||
} | |||
if len(args.Arguments[0]) < minLengthForTickerName || | |||
if len(args.Arguments[0]) < int(esdtConfig.MinTokenNameLength) || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still use the const/var minLengthForTickerName
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used for ticker name
…on-estd-issue' into Fix-token-name-length-condition-on-estd-issue # Conflicts: # vm/systemSmartContracts/esdt.go