View funcs delegation #2637
View funcs delegation #2637
Conversation
| @@ -908,7 +909,7 @@ func (sc *scProcessor) isSCExecutionAfterBuiltInFunc( | |||
| CallValue: big.NewInt(0), | |||
| CallType: callType, | |||
| GasPrice: vmInput.GasPrice, | |||
| GasProvided: vmOutput.GasRemaining - vmInput.GasLocked, | |||
| GasProvided: scExecuteOutTransfer.GasLimit, | |||
There was a problem hiding this comment.
is this backwards compatible?
There was a problem hiding this comment.
Yes it is. This feature is under built in functions
| @@ -1966,6 +1980,85 @@ func (d *delegation) getClaimableRewards(args *vmcommon.ContractCallInput) vmcom | |||
| return vmcommon.Ok | |||
| } | |||
|
|
|||
| func (d *delegation) isDelegator(args *vmcommon.ContractCallInput) vmcommon.ReturnCode { | |||
There was a problem hiding this comment.
Please add these functions in the Jira task list so we can have unit tests for them.
There was a problem hiding this comment.
Bogdan already did it and opened PR
There was a problem hiding this comment.
We can easily forget about them if the PRs overlap
There was a problem hiding this comment.
the PR with unit tests is directed to this branch. We are safe
There was a problem hiding this comment.
You forgot to test a function
…-unit-tests EN-8537: unit tests for new view functions
| @@ -313,7 +313,7 @@ func (d *delegationManager) getAllContractAddresses(args *vmcommon.ContractCallI | |||
| return vmcommon.UserError | |||
| } | |||
|
|
|||
| for _, address := range contractList.Addresses { | |||
| for _, address := range contractList.Addresses[1:] { | |||
There was a problem hiding this comment.
You should add a check that len(contractList.Addresses)>0, otherwise this will panic.
There was a problem hiding this comment.
at initialization it will be at least one. I can add for extra security.
There was a problem hiding this comment.
Function getUserUnDelegatedList not tested @bogdan-rosianu. Task EN-8525 is not complete
vm/systemSmartContracts/validator.go
Outdated
| @@ -1575,6 +1587,11 @@ func (v *validatorSC) unBondTokens(args *vmcommon.ContractCallInput) vmcommon.Re | |||
| return vmcommon.Ok | |||
| } | |||
|
|
|||
| if registrationData.NumRegistered > 0 && registrationData.TotalStakeValue.Cmp(v.minDeposit) < 0 { | |||
| v.eei.AddReturnMessage("cannot unStake tokens, the validator would remain without min deposit, nodes are still active") | |||
|
|
||
| callFunctionAndCheckResult(t, "unBondTokens", sc, caller, nil, zero, vmcommon.UserError) | ||
| vmOutput := eei.CreateVMOutput() | ||
| assert.True(t, strings.Contains(vmOutput.ReturnMessage, "cannot unStake tokens, the validator would remain without min deposit, nodes are still active")) |
sasurobert
dismissed stale reviews from iulianpascalau and BeniaminDrasovean
via
4349dd2
sasurobert
dismissed stale reviews from SebastianMarian and iulianpascalau
via
09e205f
En 8504 esdt sc call tests
…t-conf-api added gradient value in network config api route
added top up factor in network config api route
| return vmcommon.UserError | ||
| } | ||
| if args.CallValue.Cmp(zero) != 0 { | ||
| return vmcommon.UserError |
There was a problem hiding this comment.
No s.eei.AddReturnMessage ?
| @@ -120,6 +120,7 @@ func (e *esdtTransfer) ProcessBuiltinFunction( | |||
| } | |||
|
|
|||
| if isSCCallAfter { | |||
| vmOutput.GasRemaining = vmInput.GasProvided - e.funcGasCost | |||
There was a problem hiding this comment.
Could be negative in some edge cases? safeSub ?
There was a problem hiding this comment.
I do not think so. but added safeSub
…n-test Esdt multisign integration test
…ests Sc calling sc with esdt tests
added new view functions to delegation sc
added protection of unStaking / unBonding all tokens when there are active nodes
take out warm instance from config
added integration tests for different scenarios